Simplify customizing OAuth2AuthorizationRequest #7748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgrandja
added
in: oauth2
This was referenced Dec 17, 2019
jgrandja
force-pushed
the
gh-7696-authz-req-customizer
branch
from
06fcbf8 to
3e85fb8
Compare
jgrandja
force-pushed
the
gh-7696-authz-req-customizer
branch
from
3e85fb8 to
23ce717
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
OAuth2AuthorizationRequestResolverprovides the ability to customize the Authorization Request using a delegation-based strategy.Although this strategy could fulfill most (if not all) use cases, it does require some extra configuration that may not be as convenient compared to directly "hooking" into the
OAuth2AuthorizationRequest.Builderfor customizations.This PR addresses this by introducing a
Consumer<OAuth2AuthorizationRequest.Builder>inDefaultOAuth2AuthorizationRequestResolver.Fixes gh-7696
Related #7714